Skip to content

Update asyncfile.nim: support write to > 2GB file on Windows #25105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2025
Merged

Update asyncfile.nim: support write to > 2GB file on Windows #25105

merged 1 commit into from
Sep 10, 2025

Conversation

foldl
Copy link
Contributor

@foldl foldl commented Aug 17, 2025 •
edited
Loading

DWORD is defined as int32, so DWORD(...) would not work as expected. When writing to files larger than 2GB, exception occurs:

unhandled exception: value out of range: 4294967295 notin -2147483648 .. 2147483647 [RangeDefect]

This PR is a quick fix for this.

P.S. Why DWORD is defined as int32?

@foldl
Update asyncfile.nim: support write to > 2GB file on Windows
0799a9c 
`DWORD` is defined as `int32`, so this would not work as expected. When writing to files larger than 2GB, exception occurs:

```
unhandled exception: value out of range: 4294967295 notin -2147483648 .. 2147483647 [RangeDefect]
```

This PR is a quick fix for this.

P.S. Why `DWORD` is defined as `int32`?
@ringabout
Copy link
Member

See also #12327

@Araq Araq merged commit 4f09675 into nim-lang:devel Sep 10, 2025
14 of 18 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from 4f09675

Hint: mm: orc; opt: speed; options: -d:release
183028 lines; 9.053s; 659.957MiB peakmem

@foldl foldl deleted the patch-file-offset branch September 10, 2025 14:51
narimiran pushed a commit that referenced this pull request Sep 12, 2025
@foldl @narimiran
Update asyncfile.nim: support write to > 2GB file on Windows (#25105)
031bbcd 
`DWORD` is defined as `int32`, so `DWORD(...)` would not work as
expected. When writing to files larger than 2GB, exception occurs:

```
unhandled exception: value out of range: 4294967295 notin -2147483648 .. 2147483647 [RangeDefect]
```

This PR is a quick fix for this.

P.S. Why `DWORD` is defined as `int32`?

(cherry picked from commit 4f09675)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@foldl @ringabout @Araq